[Tiki-devel] Optional schema patch?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Tiki-devel] Optional schema patch?

Cloutier, Philippe (DGARI-Consultant)
I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
However the fix does not fix the broken articles created before the fix is applied. A SQL query can "fix" articles, but it is not really clean (it has advantages and disadvantages).

Do we have a way to add an optional patch, which admins could be instructed to apply using a shell command? Or just a place/convention for such optional patches?


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Optional schema patch?

Dr. Sassafras
Is the only down side of the sql "fix" that articles that previously had no reads counted will now count at "0"? If so, it should be placed in the update script and applied to everyone. A note can be added (maybe to update notes) that explains the situation.

Is there an additional down side here? Will it delete previously counted (and working) counts?

Brendan

> On Jul 28, 2017, at 11:31 AM, Cloutier, Philippe (DGARI-Consultant) <[hidden email]> wrote:
>
> I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
> However the fix does not fix the broken articles created before the fix is applied. A SQL query can "fix" articles, but it is not really clean (it has advantages and disadvantages).
>
> Do we have a way to add an optional patch, which admins could be instructed to apply using a shell command? Or just a place/convention for such optional patches?
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Optional schema patch?

Cloutier, Philippe (DGARI-Consultant)
Hi Brendan,
Yes, it is the only downside. I would agree that if we could prompt the admin what to do, it should be run by default. But I'm still uncomfortable with forcibly running that.

> -----Message d'origine-----
> De : Dr. Sassafras [mailto:[hidden email]]
> Envoyé : 28 juillet 2017 12:59
> À : Tiki developers <[hidden email]>
> Objet : Re: [Tiki-devel] Optional schema patch?
>
> Is the only down side of the sql "fix" that articles that previously had no reads counted will now count
> at "0"? If so, it should be placed in the update script and applied to everyone. A note can be added
> (maybe to update notes) that explains the situation.
>
> Is there an additional down side here? Will it delete previously counted (and working) counts?
>
> Brendan
>
> > On Jul 28, 2017, at 11:31 AM, Cloutier, Philippe (DGARI-Consultant)
> <[hidden email]> wrote:
> >
> > I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
> > However the fix does not fix the broken articles created before the fix is applied. A SQL query can
> "fix" articles, but it is not really clean (it has advantages and disadvantages).
> >
> > Do we have a way to add an optional patch, which admins could be instructed to apply using a shell
> command? Or just a place/convention for such optional patches?
> >
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > TikiWiki-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Optional schema patch?

Dr. Sassafras
Hmm. Most users of tiki won't get what the deal is, and most won't have shell access.

I'm not sure "half fixing" this is ideal.

Brendan

> On Jul 28, 2017, at 1:42 PM, Cloutier, Philippe (DGARI-Consultant) <[hidden email]> wrote:
>
> Hi Brendan,
> Yes, it is the only downside. I would agree that if we could prompt the admin what to do, it should be run by default. But I'm still uncomfortable with forcibly running that.
>
>> -----Message d'origine-----
>> De : Dr. Sassafras [mailto:[hidden email]]
>> Envoyé : 28 juillet 2017 12:59
>> À : Tiki developers <[hidden email]>
>> Objet : Re: [Tiki-devel] Optional schema patch?
>>
>> Is the only down side of the sql "fix" that articles that previously had no reads counted will now count
>> at "0"? If so, it should be placed in the update script and applied to everyone. A note can be added
>> (maybe to update notes) that explains the situation.
>>
>> Is there an additional down side here? Will it delete previously counted (and working) counts?
>>
>> Brendan
>>
>>> On Jul 28, 2017, at 11:31 AM, Cloutier, Philippe (DGARI-Consultant)
>> <[hidden email]> wrote:
>>>
>>> I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
>>> However the fix does not fix the broken articles created before the fix is applied. A SQL query can
>> "fix" articles, but it is not really clean (it has advantages and disadvantages).
>>>
>>> Do we have a way to add an optional patch, which admins could be instructed to apply using a shell
>> command? Or just a place/convention for such optional patches?
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> TikiWiki-devel mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Optional schema patch?

Cloutier, Philippe (DGARI-Consultant)
What I proposed is certainly not ideal. Ideally, we would have infrastructure for schema updates to prompt admins and behave accordingly.

I asked for help to implement what I think is the best solution possible with our current infrastructure/resources.

> -----Message d'origine-----
> De : Dr. Sassafras [mailto:[hidden email]]
> Envoyé : 28 juillet 2017 14:45
> À : Tiki developers <[hidden email]>
> Objet : Re: [Tiki-devel] Optional schema patch?
>
> Hmm. Most users of tiki won't get what the deal is, and most won't have shell access.
>
> I'm not sure "half fixing" this is ideal.
>
> Brendan
>
> > On Jul 28, 2017, at 1:42 PM, Cloutier, Philippe (DGARI-Consultant) <Philippe.Cloutier.externe@mern-
> mffp.gouv.qc.ca> wrote:
> >
> > Hi Brendan,
> > Yes, it is the only downside. I would agree that if we could prompt the admin what to do, it should be
> run by default. But I'm still uncomfortable with forcibly running that.
> >
> >> -----Message d'origine-----
> >> De : Dr. Sassafras [mailto:[hidden email]]
> >> Envoyé : 28 juillet 2017 12:59
> >> À : Tiki developers <[hidden email]>
> >> Objet : Re: [Tiki-devel] Optional schema patch?
> >>
> >> Is the only down side of the sql "fix" that articles that previously had no reads counted will now
> count
> >> at "0"? If so, it should be placed in the update script and applied to everyone. A note can be added
> >> (maybe to update notes) that explains the situation.
> >>
> >> Is there an additional down side here? Will it delete previously counted (and working) counts?
> >>
> >> Brendan
> >>
> >>> On Jul 28, 2017, at 11:31 AM, Cloutier, Philippe (DGARI-Consultant)
> >> <[hidden email]> wrote:
> >>>
> >>> I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
> >>> However the fix does not fix the broken articles created before the fix is applied. A SQL query can
> >> "fix" articles, but it is not really clean (it has advantages and disadvantages).
> >>>
> >>> Do we have a way to add an optional patch, which admins could be instructed to apply using a
> shell
> >> command? Or just a place/convention for such optional patches?
> >>>
> >>>
> >>> ------------------------------------------------------------------------------
> >>> Check out the vibrant tech community on one of the world's most
> >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >>> _______________________________________________
> >>> TikiWiki-devel mailing list
> >>> [hidden email]
> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >>
> >> ------------------------------------------------------------------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> _______________________________________________
> >> TikiWiki-devel mailing list
> >> [hidden email]
> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > TikiWiki-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Optional schema patch?

Marc Laporte-3
In reply to this post by Cloutier, Philippe (DGARI-Consultant)
Thanks for this Philippe. I had noticed some weirdness on article read
count in some projects, but I couldn't figure out the pattern. Great
detective work!

As for the SQL query, it is possible to use PHP as well:
https://dev.tiki.org/Database-Schema-Upgrade#Create_New_PHP_Patch

So there could be a check for some sort of condition, either directly
on the data, or for admin input.

Best regards,

M ;-)

On Fri, Jul 28, 2017 at 11:31 AM, Cloutier, Philippe
(DGARI-Consultant) <[hidden email]>
wrote:

> I fixed a bug which "corrupted" new articles: https://dev.tiki.org/item6014
> However the fix does not fix the broken articles created before the fix is applied. A SQL query can "fix" articles, but it is not really clean (it has advantages and disadvantages).
>
> Do we have a way to add an optional patch, which admins could be instructed to apply using a shell command? Or just a place/convention for such optional patches?
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



--
Marc Laporte

http://WikiSuite.org
http://PluginProblems.com
http://Avan.Tech

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Loading...