[Tiki-devel] Composer patches failing in trunk

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Tiki-devel] Composer patches failing in trunk

Jean-Marc Libs
Hi devs,

I have just installed some trunk instance and I see new (for me) worrying failure messages on the composer command:

Gathering patches from patch file.
Gathering patches for dependencies. This might take a minute.
  - Installing adodb/adodb-php (v5.20.9): Loading from cache
  - Applying patches for adodb/adodb-php
    ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch (Remove references to ADOdb Extension)
   Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch
    ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch (Remove the check for ADOdb Extension)
   Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch

  - Installing components/bootstrap (3.3.7): Loading from cache
  - Installing jquery/jquery-sheet (3.1): Loading from cache
  - Applying patches for jquery/jquery-sheet
    ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch (Fix visibility issues)
   Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch

Talk about useless error messages !
The site seems to work fine. Anything I should be worried about? Known issue?

Cheers,
Jyhem


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Tiki-devel] Composer patches failing in trunk

Marc Laporte-3
It's because the patch utility is not installed on the server. It happens since Ricardo added this to patch Composer libs:
https://github.com/cweagans/composer-patches

Ricardo is looking into an implementation in PHP. We are waiting from an answer from a developer.

These patches fix some issues on upstream Composer libs. I suggest you just install patch or ignore for now. They are usually obscure bugs on less active Composer libs.

Best regards,

M ;-)





On Monday, June 26, 2017, Jean-Marc Libs <[hidden email]> wrote:

> Hi devs,
>
> I have just installed some trunk instance and I see new (for me) worrying failure messages on the composer command:
>
> Gathering patches from patch file.
> Gathering patches for dependencies. This might take a minute.
>   - Installing adodb/adodb-php (v5.20.9): Loading from cache
>   - Applying patches for adodb/adodb-php
>     ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch (Remove references to ADOdb Extension)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch
>     ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch (Remove the check for ADOdb Extension)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch
>
>   - Installing components/bootstrap (3.3.7): Loading from cache
>   - Installing jquery/jquery-sheet (3.1): Loading from cache
>   - Applying patches for jquery/jquery-sheet
>     ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch (Fix visibility issues)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch
>
> Talk about useless error messages !
> The site seems to work fine. Anything I should be worried about? Known issue?
>
> Cheers,
> Jyhem
>
>

--
Marc Laporte

http://WikiSuite.org
http://PluginProblems.com
http://Avan.Tech

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Tiki-devel] Composer patches failing in trunk

Ricardo Melo
Hi Jean-Marc,

As Marc mentioned, composer patch (https://github.com/cweagans/composer-patches) uses either the command line "patch" or "git" to apply the patch, if you want to get rid of the errors, just install one of them, if not, you can either patch the files manually (using the patch in the folder installer/composer-patches) but if you don't have the adodb php extension enabled or use the sheet plugin then won't impact you.

Best Regards,
Ricardo

On Mon, Jun 26, 2017 at 7:28 PM, Marc Laporte <[hidden email]> wrote:
It's because the patch utility is not installed on the server. It happens since Ricardo added this to patch Composer libs:
https://github.com/cweagans/composer-patches

Ricardo is looking into an implementation in PHP. We are waiting from an answer from a developer.

These patches fix some issues on upstream Composer libs. I suggest you just install patch or ignore for now. They are usually obscure bugs on less active Composer libs.

Best regards,

M ;-)






On Monday, June 26, 2017, Jean-Marc Libs <[hidden email]> wrote:

> Hi devs,
>
> I have just installed some trunk instance and I see new (for me) worrying failure messages on the composer command:
>
> Gathering patches from patch file.
> Gathering patches for dependencies. This might take a minute.
>   - Installing adodb/adodb-php (v5.20.9): Loading from cache
>   - Applying patches for adodb/adodb-php
>     ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch (Remove references to ADOdb Extension)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove_references_to_adodb_extension.patch
>     ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch (Remove the check for ADOdb Extension)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/adodb-php__remove-the-check-if-the-adodb-php_ext-is-enabled.patch
>
>   - Installing components/bootstrap (3.3.7): Loading from cache
>   - Installing jquery/jquery-sheet (3.1): Loading from cache
>   - Applying patches for jquery/jquery-sheet
>     ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch (Fix visibility issues)
>    Could not apply patch! Skipping. The error was: Cannot apply patch ../installer/composer-patches/jquery-sheet_fix-visibility-issues.patch
>
> Talk about useless error messages !
> The site seems to work fine. Anything I should be worried about? Known issue?
>
> Cheers,
> Jyhem
>
>

--
Marc Laporte

http://WikiSuite.org
http://PluginProblems.com
http://Avan.Tech

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel