Quantcast

[Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jonny Bradley-4
Hi all

I think it is time that we overhauled the commit tags such as [NEW], [ENH], [FIX] etc and make the documentation a bit clearer not that we have several new developers committing code (which is absolutely fantastic, by the way!).

This can be found here: https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes and in changelog.txt.

I should also say this really doesn't matter very much, so i'm not saying anyone needs to re-commit anything, it's just some ascii in the changelog file in the end so don't take this as major criticism, just trying to straighten things out :)

I can see why Ricardo decided to tag this as a NEW thing, as it's new to satis, but from my point of view it isn't a new feature in any respect. We recently added [UPD] for composer and third party library updates so i think this would suit that.

However, the difference between NEW and ENH and MOD is always a bit blurry, i've generally taken NEW to be for things that would need a new page on doc.tiki.org (a new plugin, field type or feature) and ENH as a new section or paragraph on an existing DOC page. MOD is all together more mysterious... ;)

Do we need any new tags? Maybe CSS which was discussed before once?

I think they should be easier to find on dev.t.o, maybe on it's own page and then be included in others?

Anyway, i thought i'd start the discussion off, the main thing is that things are being fixed and added, and that's great! Something for the https://tiki.org/TikiFestFosdem2017 maybe?

jonny






> On 20 Jan 2017, at 00:48, [hidden email] wrote:
>
> Revision: 60944
>          http://sourceforge.net/p/tikiwiki/code/60944
> Author:   rjsmelo
> Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
> Log Message:
> -----------
> [NEW] Upgrade adodb to 5.20.9, add package to satis
>
> Modified Paths:
> --------------
>    trunk/doc/devtools/satis.json
>
> Modified: trunk/doc/devtools/satis.json
> ===================================================================
> --- trunk/doc/devtools/satis.json 2017-01-20 00:12:26 UTC (rev 60943)
> +++ trunk/doc/devtools/satis.json 2017-01-20 00:48:30 UTC (rev 60944)
> @@ -20,6 +20,17 @@
> {
> "type": "package",
> "package": {
> + "name": "adodb/adodb-php",
> + "version": "5.20.9",
> + "dist": {
> + "url": "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip",
> + "type": "zip"
> + }
> + }
> + },
> + {
> + "type": "package",
> + "package": {
> "name": "afarkas/html5shiv",
> "version": "3.6.2",
> "dist": {
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Tikiwiki-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Bernard Sfez-3
+1 for better clarity.

Anyway, i thought i'd start the discussion off, the main thing is that things are being fixed and added, and that's great! Something for the https://tiki.org/TikiFestFosdem2017 maybe?



On 20 Jan 2017, at 14:43 , Jonny Bradley <[hidden email]> wrote:

Hi all

I think it is time that we overhauled the commit tags such as [NEW], [ENH], [FIX] etc and make the documentation a bit clearer not that we have several new developers committing code (which is absolutely fantastic, by the way!).

This can be found here: https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes and in changelog.txt.

I should also say this really doesn't matter very much, so i'm not saying anyone needs to re-commit anything, it's just some ascii in the changelog file in the end so don't take this as major criticism, just trying to straighten things out :)

I can see why Ricardo decided to tag this as a NEW thing, as it's new to satis, but from my point of view it isn't a new feature in any respect. We recently added [UPD] for composer and third party library updates so i think this would suit that.

However, the difference between NEW and ENH and MOD is always a bit blurry, i've generally taken NEW to be for things that would need a new page on doc.tiki.org (a new plugin, field type or feature) and ENH as a new section or paragraph on an existing DOC page. MOD is all together more mysterious... ;)

Do we need any new tags? Maybe CSS which was discussed before once?

I think they should be easier to find on dev.t.o, maybe on it's own page and then be included in others?

Anyway, i thought i'd start the discussion off, the main thing is that things are being fixed and added, and that's great! Something for the https://tiki.org/TikiFestFosdem2017 maybe?

jonny






On 20 Jan 2017, at 00:48, [hidden email] wrote:

Revision: 60944
        http://sourceforge.net/p/tikiwiki/code/60944
Author:   rjsmelo
Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
Log Message:
-----------
[NEW] Upgrade adodb to 5.20.9, add package to satis

Modified Paths:
--------------
  trunk/doc/devtools/satis.json

Modified: trunk/doc/devtools/satis.json
===================================================================
--- trunk/doc/devtools/satis.json 2017-01-20 00:12:26 UTC (rev 60943)
+++ trunk/doc/devtools/satis.json 2017-01-20 00:48:30 UTC (rev 60944)
@@ -20,6 +20,17 @@
{
"type": "package",
"package": {
+ "name": "adodb/adodb-php",
+ "version": "5.20.9",
+ "dist": {
+ "url": "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip",
+ "type": "zip"
+ }
+ }
+ },
+ {
+ "type": "package",
+ "package": {
"name": "afarkas/html5shiv",
"version": "3.6.2",
"dist": {

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Tikiwiki-cvs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Brendan Ferguson
In reply to this post by Jonny Bradley-4
Ya, im up for that.

The CSS, THE, TEM, DES, .... or something that denotes that its a change made that could effect template design somewhere down the cascade line. That means ether a css change in tiki_base (that could effect our themes, or custom themes) or a change in HTML structure (that could mismatch css selectors) or a removal of a class or ID (that could effect css selectors). Might be a good way to track down regressions in css.

I would like to see them on there own page. When I make commits I very often do a google search for "Tiki Commit Codes" and give them a once over. I never want to spend a lot of time on it and scrolling to the bottom of the page is a pain. A Short and long description would also be handy, so an overview is posable, with more detail if im not exactly sure, or if Ive chosen the code I want to use, but just want to make sure it fits properly.

Brendan

On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]> wrote:
Hi all

I think it is time that we overhauled the commit tags such as [NEW], [ENH], [FIX] etc and make the documentation a bit clearer not that we have several new developers committing code (which is absolutely fantastic, by the way!).

This can be found here: https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes and in changelog.txt.

I should also say this really doesn't matter very much, so i'm not saying anyone needs to re-commit anything, it's just some ascii in the changelog file in the end so don't take this as major criticism, just trying to straighten things out :)

I can see why Ricardo decided to tag this as a NEW thing, as it's new to satis, but from my point of view it isn't a new feature in any respect. We recently added [UPD] for composer and third party library updates so i think this would suit that.

However, the difference between NEW and ENH and MOD is always a bit blurry, i've generally taken NEW to be for things that would need a new page on doc.tiki.org (a new plugin, field type or feature) and ENH as a new section or paragraph on an existing DOC page. MOD is all together more mysterious... ;)

Do we need any new tags? Maybe CSS which was discussed before once?

I think they should be easier to find on dev.t.o, maybe on it's own page and then be included in others?

Anyway, i thought i'd start the discussion off, the main thing is that things are being fixed and added, and that's great! Something for the https://tiki.org/TikiFestFosdem2017 maybe?

jonny






> On 20 Jan 2017, at 00:48, [hidden email] wrote:
>
> Revision: 60944
>          http://sourceforge.net/p/tikiwiki/code/60944
> Author:   rjsmelo
> Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
> Log Message:
> -----------
> [NEW] Upgrade adodb to 5.20.9, add package to satis
>
> Modified Paths:
> --------------
>    trunk/doc/devtools/satis.json
>
> Modified: trunk/doc/devtools/satis.json
> ===================================================================
> --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26 UTC (rev 60943)
> +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30 UTC (rev 60944)
> @@ -20,6 +20,17 @@
>               {
>                       "type": "package",
>                       "package": {
> +                             "name": "adodb/adodb-php",
> +                             "version": "5.20.9",
> +                             "dist": {
> +                                     "url": "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip",
> +                                     "type": "zip"
> +                             }
> +                     }
> +             },
> +             {
> +                     "type": "package",
> +                     "package": {
>                               "name": "afarkas/html5shiv",
>                               "version": "3.6.2",
>                               "dist": {
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Tikiwiki-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Gary Cunningham-Lee
Hi,

I need to follow CSS changes too, but I just check which directories or
files are involved in a commit; if it's in the themes directories, I
know it's a CSS change (or Less + CSS change).

Is the idea that the [CSS] tag would be used in combination with one of
the others, like [CSS][FIX], etc.? That seems ok to me. Using only [CSS]
wouldn't give enough information or the right information IMO. But then
if CSS file changes warrant a tag, is the same true for other file
types? (Thinking about adding a [CSS] tag, I kind of see this situation
as a matrix with the nature-of-the-change tags on one axis and file
types - or other category that [CSS] fits in - on another.)

-- Gary


On 1/22/2017 8:10 PM, Brendan Ferguson wrote:

> Ya, im up for that.
>
> The CSS, THE, TEM, DES, .... or something that denotes that its a change
> made that could effect template design somewhere down the cascade line.
> That means ether a css change in tiki_base (that could effect our
> themes, or custom themes) or a change in HTML structure (that could
> mismatch css selectors) or a removal of a class or ID (that could effect
> css selectors). Might be a good way to track down regressions in css.
>
> I would like to see them on there own page. When I make commits I very
> often do a google search for "Tiki Commit Codes" and give them a once
> over. I never want to spend a lot of time on it and scrolling to the
> bottom of the page is a pain. A Short and long description would also be
> handy, so an overview is posable, with more detail if im not exactly
> sure, or if Ive chosen the code I want to use, but just want to make
> sure it fits properly.
>
> Brendan
>
> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi all
>
>     I think it is time that we overhauled the commit tags such as [NEW],
>     [ENH], [FIX] etc and make the documentation a bit clearer not that
>     we have several new developers committing code (which is absolutely
>     fantastic, by the way!).
>
>     This can be found here:
>     https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes> and
>     in changelog.txt.
>
>     I should also say this really doesn't matter very much, so i'm not
>     saying anyone needs to re-commit anything, it's just some ascii in
>     the changelog file in the end so don't take this as major criticism,
>     just trying to straighten things out :)
>
>     I can see why Ricardo decided to tag this as a NEW thing, as it's
>     new to satis, but from my point of view it isn't a new feature in
>     any respect. We recently added [UPD] for composer and third party
>     library updates so i think this would suit that.
>
>     However, the difference between NEW and ENH and MOD is always a bit
>     blurry, i've generally taken NEW to be for things that would need a
>     new page on doc.tiki.org <http://doc.tiki.org> (a new plugin, field
>     type or feature) and ENH as a new section or paragraph on an
>     existing DOC page. MOD is all together more mysterious... ;)
>
>     Do we need any new tags? Maybe CSS which was discussed before once?
>
>     I think they should be easier to find on dev.t.o, maybe on it's own
>     page and then be included in others?
>
>     Anyway, i thought i'd start the discussion off, the main thing is
>     that things are being fixed and added, and that's great! Something
>     for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017> maybe?
>
>     jonny
>
>
>
>
>
>
>     > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]> wrote:
>     >
>     > Revision: 60944
>     >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     > Author:   rjsmelo
>     > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     > Log Message:
>     > -----------
>     > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >
>     > Modified Paths:
>     > --------------
>     >    trunk/doc/devtools/satis.json
>     >
>     > Modified: trunk/doc/devtools/satis.json
>     > ===================================================================
>     > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26 UTC (rev
>     60943)
>     > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30 UTC (rev
>     60944)
>     > @@ -20,6 +20,17 @@
>     >               {
>     >                       "type": "package",
>     >                       "package": {
>     > +                             "name": "adodb/adodb-php",
>     > +                             "version": "5.20.9",
>     > +                             "dist": {
>     > +                                     "url":
>     "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>",
>     > +                                     "type": "zip"
>     > +                             }
>     > +                     }
>     > +             },
>     > +             {
>     > +                     "type": "package",
>     > +                     "package": {
>     >                               "name": "afarkas/html5shiv",
>     >                               "version": "3.6.2",
>     >                               "dist": {
>     >
>     > This was sent by the SourceForge.net collaborative development
>     platform, the world's largest Open Source development site.
>     >
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > Tikiwiki-cvs mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

luciash d' being
Hi,

I agree the [CSS] would need to go together with [FIX] etc.

Maybe for template changes we could have [TPL] too, but I would rather
not go too wild with introducing new commit "tags".

luci


On 22.1.2017 14:11, Gary Cunningham-Lee wrote:

> Hi,
>
> I need to follow CSS changes too, but I just check which directories or
> files are involved in a commit; if it's in the themes directories, I
> know it's a CSS change (or Less + CSS change).
>
> Is the idea that the [CSS] tag would be used in combination with one of
> the others, like [CSS][FIX], etc.? That seems ok to me. Using only [CSS]
> wouldn't give enough information or the right information IMO. But then
> if CSS file changes warrant a tag, is the same true for other file
> types? (Thinking about adding a [CSS] tag, I kind of see this situation
> as a matrix with the nature-of-the-change tags on one axis and file
> types - or other category that [CSS] fits in - on another.)
>
> -- Gary
>
>
> On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>> Ya, im up for that.
>>
>> The CSS, THE, TEM, DES, .... or something that denotes that its a change
>> made that could effect template design somewhere down the cascade line.
>> That means ether a css change in tiki_base (that could effect our
>> themes, or custom themes) or a change in HTML structure (that could
>> mismatch css selectors) or a removal of a class or ID (that could effect
>> css selectors). Might be a good way to track down regressions in css.
>>
>> I would like to see them on there own page. When I make commits I very
>> often do a google search for "Tiki Commit Codes" and give them a once
>> over. I never want to spend a lot of time on it and scrolling to the
>> bottom of the page is a pain. A Short and long description would also be
>> handy, so an overview is posable, with more detail if im not exactly
>> sure, or if Ive chosen the code I want to use, but just want to make
>> sure it fits properly.
>>
>> Brendan
>>
>> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>      Hi all
>>
>>      I think it is time that we overhauled the commit tags such as [NEW],
>>      [ENH], [FIX] etc and make the documentation a bit clearer not that
>>      we have several new developers committing code (which is absolutely
>>      fantastic, by the way!).
>>
>>      This can be found here:
>>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>>      <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes> and
>>      in changelog.txt.
>>
>>      I should also say this really doesn't matter very much, so i'm not
>>      saying anyone needs to re-commit anything, it's just some ascii in
>>      the changelog file in the end so don't take this as major criticism,
>>      just trying to straighten things out :)
>>
>>      I can see why Ricardo decided to tag this as a NEW thing, as it's
>>      new to satis, but from my point of view it isn't a new feature in
>>      any respect. We recently added [UPD] for composer and third party
>>      library updates so i think this would suit that.
>>
>>      However, the difference between NEW and ENH and MOD is always a bit
>>      blurry, i've generally taken NEW to be for things that would need a
>>      new page on doc.tiki.org <http://doc.tiki.org> (a new plugin, field
>>      type or feature) and ENH as a new section or paragraph on an
>>      existing DOC page. MOD is all together more mysterious... ;)
>>
>>      Do we need any new tags? Maybe CSS which was discussed before once?
>>
>>      I think they should be easier to find on dev.t.o, maybe on it's own
>>      page and then be included in others?
>>
>>      Anyway, i thought i'd start the discussion off, the main thing is
>>      that things are being fixed and added, and that's great! Something
>>      for the https://tiki.org/TikiFestFosdem2017
>>      <https://tiki.org/TikiFestFosdem2017> maybe?
>>
>>      jonny
>>
>>
>>
>>
>>
>>
>>      > On 20 Jan 2017, at 00:48, [hidden email]
>>      <mailto:[hidden email]> wrote:
>>      >
>>      > Revision: 60944
>>      >          http://sourceforge.net/p/tikiwiki/code/60944
>>      <http://sourceforge.net/p/tikiwiki/code/60944>
>>      > Author:   rjsmelo
>>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>>      > Log Message:
>>      > -----------
>>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>>      >
>>      > Modified Paths:
>>      > --------------
>>      >    trunk/doc/devtools/satis.json
>>      >
>>      > Modified: trunk/doc/devtools/satis.json
>>      > ===================================================================
>>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26 UTC (rev
>>      60943)
>>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30 UTC (rev
>>      60944)
>>      > @@ -20,6 +20,17 @@
>>      >               {
>>      >                       "type": "package",
>>      >                       "package": {
>>      > +                             "name": "adodb/adodb-php",
>>      > +                             "version": "5.20.9",
>>      > +                             "dist": {
>>      > +                                     "url":
>>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>",
>>      > +                                     "type": "zip"
>>      > +                             }
>>      > +                     }
>>      > +             },
>>      > +             {
>>      > +                     "type": "package",
>>      > +                     "package": {
>>      >                               "name": "afarkas/html5shiv",
>>      >                               "version": "3.6.2",
>>      >                               "dist": {
>>      >
>>      > This was sent by the SourceForge.net collaborative development
>>      platform, the world's largest Open Source development site.
>>      >
>>      >
>>      >
>>      ------------------------------------------------------------------------------
>>      > Check out the vibrant tech community on one of the world's most
>>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      > _______________________________________________
>>      > Tikiwiki-cvs mailing list
>>      > [hidden email]
>>      <mailto:[hidden email]>
>>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>>      >
>>
>>
>>      ------------------------------------------------------------------------------
>>      Check out the vibrant tech community on one of the world's most
>>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      _______________________________________________
>>      TikiWiki-devel mailing list
>>      [hidden email]
>>      <mailto:[hidden email]>
>>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Brendan Ferguson
ya, I was thinking one code that would describe something that might break themes. It would have to be combined with another tag... like a descriptor. The [DB] tag seems to be similar. It does not describe what the change does, only denotes that a particular part of the code is being modified.

Perhaps we should also separate these two types of codes in the new description. With one code for what the commit does, and then optional codes placed to track a specific aspect of the commit.

I refined my thoghts a little over the night.
1. Any CSS change made within tiki_base
2. Any html structure change
3. Any removal of a class or id

Whats not included
Changes to css made outside of tiki_base
2. Addition of classes that are unlikely to cause rule conflicts

Or do you think that is too complex. Just one code for all HTML-CSS changes? Would that be better anyhow?

[HTM]
[CSS]
[TPL]
Any better options?

Below is a draft of a few changes... vote them down or up, or just plain modify it as your better idea. Its certainly a work in progress. I moved the security to the secondary tags, (why cant a REM, or MOD be a security fix?) And also added [COM] which was suggested by Filipus. The only other idea, is to perhaps have about 5 examples for each code, which will only be seen upon hovering over the description. They could just be pulled from our current commits (assuming they were tagged well)

Commit Codes

Coding Changes:
  • [ENH] Enhancement - For performance, look and feel, or other changes that make tiki work better.
  • [FIX] Bug Fixes - for bug fixes of any sort
  • [MOD] Behavior Modification - Is a change in how things work, which may disrupt user habits, for example, changing the default value of an optio.
  • [REF] Refactoring - Changes the structure of the code (to make it cleaner or clearer), without changing its actual behavior.
  • [NEW] New Features - For additions of new features
  • [REM] Feature Removal - For removal of old features
  • [UPD] Vendor Updates - For updates of third party/vendor libraries

Property Tracking (used in addition to one of the above):

  • [DB] Database - For any change to the database
  • [TPL] HTML & CSS - For changes made to html or css (perhaps only changes that could cause conflicts?)
  • [SEC] Security - For security fix operations

Non-Coding Related:

  • [KIL] File Removal - Removals of unused or obsolete files
  • [COM] Code Comments - Addition, clarification or deletion of developer comments
  • [DOC] Documentation improvements - For Improvements in the tips or contextual documentation provided to the user/admin.
  • [TRA] Translation
  • [REL] Release Process
  • [MRG] Branch Merges - Generally performed by the merge script

Backports:

  • [bp/r000] Where 000 is the commit number being backported. This should be added to the beginning of each backport. eg. [bp/r28500] [FIX] ...


On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]> wrote:
Hi,

I agree the [CSS] would need to go together with [FIX] etc.

Maybe for template changes we could have [TPL] too, but I would rather
not go too wild with introducing new commit "tags".

luci


On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
> Hi,
>
> I need to follow CSS changes too, but I just check which directories or
> files are involved in a commit; if it's in the themes directories, I
> know it's a CSS change (or Less + CSS change).
>
> Is the idea that the [CSS] tag would be used in combination with one of
> the others, like [CSS][FIX], etc.? That seems ok to me. Using only [CSS]
> wouldn't give enough information or the right information IMO. But then
> if CSS file changes warrant a tag, is the same true for other file
> types? (Thinking about adding a [CSS] tag, I kind of see this situation
> as a matrix with the nature-of-the-change tags on one axis and file
> types - or other category that [CSS] fits in - on another.)
>
> -- Gary
>
>
> On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>> Ya, im up for that.
>>
>> The CSS, THE, TEM, DES, .... or something that denotes that its a change
>> made that could effect template design somewhere down the cascade line.
>> That means ether a css change in tiki_base (that could effect our
>> themes, or custom themes) or a change in HTML structure (that could
>> mismatch css selectors) or a removal of a class or ID (that could effect
>> css selectors). Might be a good way to track down regressions in css.
>>
>> I would like to see them on there own page. When I make commits I very
>> often do a google search for "Tiki Commit Codes" and give them a once
>> over. I never want to spend a lot of time on it and scrolling to the
>> bottom of the page is a pain. A Short and long description would also be
>> handy, so an overview is posable, with more detail if im not exactly
>> sure, or if Ive chosen the code I want to use, but just want to make
>> sure it fits properly.
>>
>> Brendan
>>
>> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>      Hi all
>>
>>      I think it is time that we overhauled the commit tags such as [NEW],
>>      [ENH], [FIX] etc and make the documentation a bit clearer not that
>>      we have several new developers committing code (which is absolutely
>>      fantastic, by the way!).
>>
>>      This can be found here:
>>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>>      <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes> and
>>      in changelog.txt.
>>
>>      I should also say this really doesn't matter very much, so i'm not
>>      saying anyone needs to re-commit anything, it's just some ascii in
>>      the changelog file in the end so don't take this as major criticism,
>>      just trying to straighten things out :)
>>
>>      I can see why Ricardo decided to tag this as a NEW thing, as it's
>>      new to satis, but from my point of view it isn't a new feature in
>>      any respect. We recently added [UPD] for composer and third party
>>      library updates so i think this would suit that.
>>
>>      However, the difference between NEW and ENH and MOD is always a bit
>>      blurry, i've generally taken NEW to be for things that would need a
>>      new page on doc.tiki.org <http://doc.tiki.org> (a new plugin, field
>>      type or feature) and ENH as a new section or paragraph on an
>>      existing DOC page. MOD is all together more mysterious... ;)
>>
>>      Do we need any new tags? Maybe CSS which was discussed before once?
>>
>>      I think they should be easier to find on dev.t.o, maybe on it's own
>>      page and then be included in others?
>>
>>      Anyway, i thought i'd start the discussion off, the main thing is
>>      that things are being fixed and added, and that's great! Something
>>      for the https://tiki.org/TikiFestFosdem2017
>>      <https://tiki.org/TikiFestFosdem2017> maybe?
>>
>>      jonny
>>
>>
>>
>>
>>
>>
>>      > On 20 Jan 2017, at 00:48, [hidden email]
>>      <mailto:[hidden email]> wrote:
>>      >
>>      > Revision: 60944
>>      >          http://sourceforge.net/p/tikiwiki/code/60944
>>      <http://sourceforge.net/p/tikiwiki/code/60944>
>>      > Author:   rjsmelo
>>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>>      > Log Message:
>>      > -----------
>>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>>      >
>>      > Modified Paths:
>>      > --------------
>>      >    trunk/doc/devtools/satis.json
>>      >
>>      > Modified: trunk/doc/devtools/satis.json
>>      > ===================================================================
>>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26 UTC (rev
>>      60943)
>>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30 UTC (rev
>>      60944)
>>      > @@ -20,6 +20,17 @@
>>      >               {
>>      >                       "type": "package",
>>      >                       "package": {
>>      > +                             "name": "adodb/adodb-php",
>>      > +                             "version": "5.20.9",
>>      > +                             "dist": {
>>      > +                                     "url":
>>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>",
>>      > +                                     "type": "zip"
>>      > +                             }
>>      > +                     }
>>      > +             },
>>      > +             {
>>      > +                     "type": "package",
>>      > +                     "package": {
>>      >                               "name": "afarkas/html5shiv",
>>      >                               "version": "3.6.2",
>>      >                               "dist": {
>>      >
>>      > This was sent by the SourceForge.net collaborative development
>>      platform, the world's largest Open Source development site.
>>      >
>>      >
>>      >
>>      ------------------------------------------------------------------------------
>>      > Check out the vibrant tech community on one of the world's most
>>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      > _______________________________________________
>>      > Tikiwiki-cvs mailing list
>>      > [hidden email]
>>      <mailto:[hidden email]>
>>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>>      >
>>
>>
>>      ------------------------------------------------------------------------------
>>      Check out the vibrant tech community on one of the world's most
>>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      _______________________________________________
>>      TikiWiki-devel mailing list
>>      [hidden email]
>>      <mailto:[hidden email]>
>>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Amna Usman

For all HTML,  css,  tpl,  changes we can introduce tag [UI]

Regards

On Jan 23, 2017 5:33 AM, "Brendan Ferguson" <[hidden email]> wrote:
ya, I was thinking one code that would describe something that might break themes. It would have to be combined with another tag... like a descriptor. The [DB] tag seems to be similar. It does not describe what the change does, only denotes that a particular part of the code is being modified.

Perhaps we should also separate these two types of codes in the new description. With one code for what the commit does, and then optional codes placed to track a specific aspect of the commit.

I refined my thoghts a little over the night.
1. Any CSS change made within tiki_base
2. Any html structure change
3. Any removal of a class or id

Whats not included
Changes to css made outside of tiki_base
2. Addition of classes that are unlikely to cause rule conflicts

Or do you think that is too complex. Just one code for all HTML-CSS changes? Would that be better anyhow?

[HTM]
[CSS]
[TPL]
Any better options?

Below is a draft of a few changes... vote them down or up, or just plain modify it as your better idea. Its certainly a work in progress. I moved the security to the secondary tags, (why cant a REM, or MOD be a security fix?) And also added [COM] which was suggested by Filipus. The only other idea, is to perhaps have about 5 examples for each code, which will only be seen upon hovering over the description. They could just be pulled from our current commits (assuming they were tagged well)

Commit Codes

Coding Changes:
  • [ENH] Enhancement - For performance, look and feel, or other changes that make tiki work better.
  • [FIX] Bug Fixes - for bug fixes of any sort
  • [MOD] Behavior Modification - Is a change in how things work, which may disrupt user habits, for example, changing the default value of an optio.
  • [REF] Refactoring - Changes the structure of the code (to make it cleaner or clearer), without changing its actual behavior.
  • [NEW] New Features - For additions of new features
  • [REM] Feature Removal - For removal of old features
  • [UPD] Vendor Updates - For updates of third party/vendor libraries

Property Tracking (used in addition to one of the above):

  • [DB] Database - For any change to the database
  • [TPL] HTML & CSS - For changes made to html or css (perhaps only changes that could cause conflicts?)
  • [SEC] Security - For security fix operations

Non-Coding Related:

  • [KIL] File Removal - Removals of unused or obsolete files
  • [COM] Code Comments - Addition, clarification or deletion of developer comments
  • [DOC] Documentation improvements - For Improvements in the tips or contextual documentation provided to the user/admin.
  • [TRA] Translation
  • [REL] Release Process
  • [MRG] Branch Merges - Generally performed by the merge script

Backports:

  • [bp/r000] Where 000 is the commit number being backported. This should be added to the beginning of each backport. eg. [bp/r28500] [FIX] ...


On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]> wrote:
Hi,

I agree the [CSS] would need to go together with [FIX] etc.

Maybe for template changes we could have [TPL] too, but I would rather
not go too wild with introducing new commit "tags".

luci


On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
> Hi,
>
> I need to follow CSS changes too, but I just check which directories or
> files are involved in a commit; if it's in the themes directories, I
> know it's a CSS change (or Less + CSS change).
>
> Is the idea that the [CSS] tag would be used in combination with one of
> the others, like [CSS][FIX], etc.? That seems ok to me. Using only [CSS]
> wouldn't give enough information or the right information IMO. But then
> if CSS file changes warrant a tag, is the same true for other file
> types? (Thinking about adding a [CSS] tag, I kind of see this situation
> as a matrix with the nature-of-the-change tags on one axis and file
> types - or other category that [CSS] fits in - on another.)
>
> -- Gary
>
>
> On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>> Ya, im up for that.
>>
>> The CSS, THE, TEM, DES, .... or something that denotes that its a change
>> made that could effect template design somewhere down the cascade line.
>> That means ether a css change in tiki_base (that could effect our
>> themes, or custom themes) or a change in HTML structure (that could
>> mismatch css selectors) or a removal of a class or ID (that could effect
>> css selectors). Might be a good way to track down regressions in css.
>>
>> I would like to see them on there own page. When I make commits I very
>> often do a google search for "Tiki Commit Codes" and give them a once
>> over. I never want to spend a lot of time on it and scrolling to the
>> bottom of the page is a pain. A Short and long description would also be
>> handy, so an overview is posable, with more detail if im not exactly
>> sure, or if Ive chosen the code I want to use, but just want to make
>> sure it fits properly.
>>
>> Brendan
>>
>> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>      Hi all
>>
>>      I think it is time that we overhauled the commit tags such as [NEW],
>>      [ENH], [FIX] etc and make the documentation a bit clearer not that
>>      we have several new developers committing code (which is absolutely
>>      fantastic, by the way!).
>>
>>      This can be found here:
>>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>>      <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes> and
>>      in changelog.txt.
>>
>>      I should also say this really doesn't matter very much, so i'm not
>>      saying anyone needs to re-commit anything, it's just some ascii in
>>      the changelog file in the end so don't take this as major criticism,
>>      just trying to straighten things out :)
>>
>>      I can see why Ricardo decided to tag this as a NEW thing, as it's
>>      new to satis, but from my point of view it isn't a new feature in
>>      any respect. We recently added [UPD] for composer and third party
>>      library updates so i think this would suit that.
>>
>>      However, the difference between NEW and ENH and MOD is always a bit
>>      blurry, i've generally taken NEW to be for things that would need a
>>      new page on doc.tiki.org <http://doc.tiki.org> (a new plugin, field
>>      type or feature) and ENH as a new section or paragraph on an
>>      existing DOC page. MOD is all together more mysterious... ;)
>>
>>      Do we need any new tags? Maybe CSS which was discussed before once?
>>
>>      I think they should be easier to find on dev.t.o, maybe on it's own
>>      page and then be included in others?
>>
>>      Anyway, i thought i'd start the discussion off, the main thing is
>>      that things are being fixed and added, and that's great! Something
>>      for the https://tiki.org/TikiFestFosdem2017
>>      <https://tiki.org/TikiFestFosdem2017> maybe?
>>
>>      jonny
>>
>>
>>
>>
>>
>>
>>      > On 20 Jan 2017, at 00:48, [hidden email]
>>      <mailto:[hidden email]> wrote:
>>      >
>>      > Revision: 60944
>>      >          http://sourceforge.net/p/tikiwiki/code/60944
>>      <http://sourceforge.net/p/tikiwiki/code/60944>
>>      > Author:   rjsmelo
>>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>>      > Log Message:
>>      > -----------
>>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>>      >
>>      > Modified Paths:
>>      > --------------
>>      >    trunk/doc/devtools/satis.json
>>      >
>>      > Modified: trunk/doc/devtools/satis.json
>>      > ===================================================================
>>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26 UTC (rev
>>      60943)
>>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30 UTC (rev
>>      60944)
>>      > @@ -20,6 +20,17 @@
>>      >               {
>>      >                       "type": "package",
>>      >                       "package": {
>>      > +                             "name": "adodb/adodb-php",
>>      > +                             "version": "5.20.9",
>>      > +                             "dist": {
>>      > +                                     "url":
>>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>",
>>      > +                                     "type": "zip"
>>      > +                             }
>>      > +                     }
>>      > +             },
>>      > +             {
>>      > +                     "type": "package",
>>      > +                     "package": {
>>      >                               "name": "afarkas/html5shiv",
>>      >                               "version": "3.6.2",
>>      >                               "dist": {
>>      >
>>      > This was sent by the SourceForge.net collaborative development
>>      platform, the world's largest Open Source development site.
>>      >
>>      >
>>      >
>>      ------------------------------------------------------------------------------
>>      > Check out the vibrant tech community on one of the world's most
>>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      > _______________________________________________
>>      > Tikiwiki-cvs mailing list
>>      > [hidden email]
>>      <mailto:[hidden email]>
>>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>>      >
>>
>>
>>      ------------------------------------------------------------------------------
>>      Check out the vibrant tech community on one of the world's most
>>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>      _______________________________________________
>>      TikiWiki-devel mailing list
>>      [hidden email]
>>      <mailto:[hidden email]>
>>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>
>>
>>
>> _______________________________________________
>> TikiWiki-devel mailing list
>> [hidden email]
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Gary Cunningham-Lee
In reply to this post by Brendan Ferguson
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:

> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Brendan Ferguson
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jean-Marc Libs
We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Brendan Ferguson

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jean-Marc Libs
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jean-Marc Libs
Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Brendan Ferguson
[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Bernard Sfez-3
Mmm…

There is (I do) a lot of commit over "cosmetics" (spaces between block, button placement, text color, etc).
I’ll be glad to have a proper tag for those.

[UX] sounded good but call anything you want as long as there is one. :)

Bernard



On 25 Jan 2017, at 01:36 , Brendan Ferguson <[hidden email]> wrote:

[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Filipus Klutiero
A change which creates a user-visible enhancement can be tagged [ENH]. But there is no need to tag every change anyway.

On 2017-01-25 00:14, Bernard Sfez wrote:
Mmm…

There is (I do) a lot of commit over "cosmetics" (spaces between block, button placement, text color, etc).
I’ll be glad to have a proper tag for those.

[UX] sounded good but call anything you want as long as there is one. :)

Bernard



On 25 Jan 2017, at 01:36 , Brendan Ferguson <[hidden email]> wrote:

[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >

-- 
Filipus Klutiero
http://www.philippecloutier.com

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Bernard Sfez-3

But there is no need to tag every change anyway.

I can live with that if the page says so. :D :D :D :D


On 2017-01-25 00:14, Bernard Sfez wrote:
Mmm…

There is (I do) a lot of commit over "cosmetics" (spaces between block, button placement, text color, etc).
I’ll be glad to have a proper tag for those.

[UX] sounded good but call anything you want as long as there is one. :)

Bernard



On 25 Jan 2017, at 01:36 , Brendan Ferguson <[hidden email]> wrote:

[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >

-- 
Filipus Klutiero
http://www.philippecloutier.com
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jonny Bradley-4
I thought only tagged ones went in the change log... maybe not?

jonny

On 25 Jan 2017, at 07:28, Bernard Sfez <[hidden email]> wrote:


But there is no need to tag every change anyway.

I can live with that if the page says so. :D :D :D :D


On 2017-01-25 00:14, Bernard Sfez wrote:
Mmm…

There is (I do) a lot of commit over "cosmetics" (spaces between block, button placement, text color, etc).
I’ll be glad to have a proper tag for those.

[UX] sounded good but call anything you want as long as there is one. :)

Bernard



On 25 Jan 2017, at 01:36 , Brendan Ferguson <[hidden email]> wrote:

[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >

-- 
Filipus Klutiero
http://www.philippecloutier.com
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Jean-Marc Libs
In reply to this post by Brendan Ferguson




On Wed, Jan 25, 2017 at 12:36 AM, Brendan Ferguson <[hidden email]> wrote:
[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It was introduced after the feb 2016 Roundtable meeting, following the UX disaster which was the easy to miss sieve icon for selecting basic/advanced/experimental/unavailable features. There was concern that ENH was for adding stuff to Tiki and we needed more focus on making it easy for people to benefit from what Tiki already has.
So «it's only ever been used 22 times» is an unfair argument because UX was not documented in the doc page and it's only been present for less than a year

+1 for moving commit codes to their own page on doc.tiki.org and have some include plugin on other wiki pages.

It needs to stay in changelog.txt also, for quick reference while coding.

Cheers,
J-M
 

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] Commit tags [e.g. Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60944] trunk/doc/devtools/satis.json]

Bernard Sfez-3
3. Remove UX (it’s only ever been used 22 times)

They may be some confusion here because I never see the tag [UX] or [UI] or [UI/UX] in this page : https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes

That’s why I may have used it once or twice before someone told me that this is not a usable tag. (was after we discussed "miss sieve icon for selecting basic/advanced/experimental/unavailable" see https://dev.tiki.org/UX)

If they were such tag I would have use it.



This is just to clarify and sorry for the blablabla, I’ll stick to what the community decide in this matter.

Bernard



On 25 Jan 2017, at 17:12 , Jean-Marc Libs <[hidden email]> wrote:





On Wed, Jan 25, 2017 at 12:36 AM, Brendan Ferguson <[hidden email]> wrote:
[UX] seems to severely overlap with [ENH] as it mentions speed and performance can be tagged as ux as well.

It was introduced after the feb 2016 Roundtable meeting, following the UX disaster which was the easy to miss sieve icon for selecting basic/advanced/experimental/unavailable features. There was concern that ENH was for adding stuff to Tiki and we needed more focus on making it easy for people to benefit from what Tiki already has.
So «it's only ever been used 22 times» is an unfair argument because UX was not documented in the doc page and it's only been present for less than a year

+1 for moving commit codes to their own page on doc.tiki.org and have some include plugin on other wiki pages.

It needs to stay in changelog.txt also, for quick reference while coding.

Cheers,
J-M
 

It also seems that one place to maintain the commit codes would be easier to maintain. 3, or even 2 places seems to be too much.

I vote to

1. Move commit codes to there own page on doc.tiki.org
2. Replace descriptions of commit codes with a link to doc.tiki.org (isn't there a plugin that allows for reusing wiki sections? We might be to have a copy appear on dev that way)
3. Remove UX (it's only ever been used 22 times)

Brendan



On Jan 25, 2017, at 8:05 AM, Jean-Marc Libs <[hidden email]> wrote:

Ouch. And right here I see another list of tags which is different from both others: https://dev.tiki.org/tiki-index.php?page_ref_id=123&pagenum=2#Step_5:_Commit_Your_Changes
What about the wiki pages mention that the lists are examples and the reference list is in changelog.txt?

Cheers,
J-M

On Tue, Jan 24, 2017 at 11:00 PM, Jean-Marc Libs <[hidden email]> wrote:
Interesting. I thought the reference was the changelog.txt in the source. That's the one I refer to when I commit. It says:
-----------------------------------------8<----------------------------------------------------------
The following tags can be used to distinguish changes:
* [NEW] for additions of new features
* [ENH] is an enhancement; not really new but makes things work better (e.g. look and feel, performance...)
* [MOD] is a change in how things work, which may disrupt user habits, for example changing the default value of an option

* [FIX] for bug fixes of any sort
* [SEC] for security fix operations (implies [FIX]). If you feel you have reason to put this tag, please first contact security at tiki.org
* [UPD] for updates of third party/vendor libraries

* [UX] for user experience improvements; makes Tiki easier to use and understand (more details in https://dev.tiki.org/UX )

* [DB] for changes in the database

* [REM] for feature removals
* [KIL] for removals of unused or obsolete files (has been used in the sense of [REM] prior to Tiki 6)


* [REF] for refactoring; changes the structure of the code (to make it cleaner or clearer), without changing its actual behaviour.
* [REL] for the release process
* [MRG] for branch merges, generally performed by the merge scripts
* [DOC] for improvements in the tips or contextual documentation provided to the user/admin
* [TRA] for translation

When possible, it's also nice to indicate what feature is concerned by the change.

Before 2.0, there was only [MOD] for both [ENH] and [MOD]
-----------------------------------------8<----------------------------------------------------------

Cheers,
J-M

On Tue, Jan 24, 2017 at 7:30 AM, Brendan Ferguson <[hidden email]> wrote:

We already have [UX]. I hope the descriptions of both will make it easy for people to not confse both.

What is [UX]? I don't see it listed here: https://dev.tiki.org/Commit+Code

Brendan
 
+1 to [UI] User Interface

Jyhem

On Tue, Jan 24, 2017 at 12:23 AM, Brendan Ferguson <[hidden email]> wrote:
That sounds good

+1 to [UI] User Interface - Any change made to HTML or CSS

On Mon, Jan 23, 2017 at 6:39 PM, Gary Cunningham-Lee <[hidden email]> wrote:
I like Amna's suggestion

 > For all HTML,  css,  tpl,  changes we can introduce tag [UI]

So the assumption with [UI] is that the change is about presentation only.

I feel kind of wary about trying to anticipate which CSS or other UI
changes might cause a problem for third-party themes. A lot depends on
what the theme author decided what to style, what particular selectors
he/she used, etc. Of course sometimes we know that some change in a .tpl
file and related CSS will require adjustments in themes, but I think
there's a big gray area where probably some themes will be ok but others
will need adjusting. Maybe just label all changes "[UI]" and expect
theme authors to check commit notices or the changelog to stay on top of
things - it's a shared responsibility.

-- Gary

On 1/23/2017 9:31 AM, Brendan Ferguson wrote:
> ya, I was thinking one code that would describe something that might
> break themes. It would have to be combined with another tag... like a
> descriptor. The [DB] tag seems to be similar. It does not describe what
> the change does, only denotes that a particular part of the code is
> being modified.
>
> Perhaps we should also separate these two types of codes in the new
> description. With one code for what the commit does, and then optional
> codes placed to track a specific aspect of the commit.
>
> I refined my thoghts a little over the night.
> 1. Any CSS change made within tiki_base
> 2. Any html structure change
> 3. Any removal of a class or id
>
> Whats not included
> Changes to css made outside of tiki_base
> 2. Addition of classes that are unlikely to cause rule conflicts
>
> Or do you think that is too complex. Just one code for all HTML-CSS
> changes? Would that be better anyhow?
>
> [HTM]
> [CSS]
> [TPL]
> Any better options?
>
> Below is a draft of a few changes... vote them down or up, or just plain
> modify it as your better idea. Its certainly a work in progress. I moved
> the security to the secondary tags, (why cant a REM, or MOD be a
> security fix?) And also added [COM] which was suggested by Filipus. The
> only other idea, is to perhaps have about 5 examples for each code,
> which will only be seen upon hovering over the description. They could
> just be pulled from our current commits (assuming they were tagged well)
>
> Commit Codes
>
> Coding Changes:
>
>   * [ENH] Enhancement - For performance, look and feel, or other changes
>     that make tiki work better.
>   * [FIX] Bug Fixes - for bug fixes of any sort
>   * [MOD] Behavior Modification - Is a change in how things work, which
>     may disrupt user habits, for example, changing the default value of
>     an optio.
>   * [REF] Refactoring - Changes the structure of the code (to make it
>     cleaner or clearer), without changing its actual behavior.
>   * [NEW] New Features - For additions of new features
>   * [REM] Feature Removal - For removal of old features
>   * [UPD] Vendor Updates - For updates of third party/vendor libraries
>
> Property Tracking (used in addition to one of the above):
>
>   * [DB] Database - For any change to the database
>   * [TPL] HTML & CSS - For changes made to html or css (perhaps only
>     changes that could cause conflicts?)
>   * [SEC] Security - For security fix operations
>
> Non-Coding Related:
>
>   * [KIL] File Removal - Removals of unused or obsolete files
>   * [COM] Code Comments - Addition, clarification or deletion of
>     developer comments
>   * [DOC] Documentation improvements - For Improvements in the tips or
>     contextual documentation provided to the user/admin.
>   * [TRA] Translation
>   * [REL] Release Process
>   * [MRG] Branch Merges - Generally performed by the merge script
>
> Backports:
>
>   * |[bp/r000] Where 000 is the commit number being backported. This
>     should be added to the beginning of each backport. eg.
>     ||*[bp/r28500] [FIX] ...*
>     |
>
>
>
> On Mon, Jan 23, 2017 at 1:29 AM, luciash <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     I agree the [CSS] would need to go together with [FIX] etc.
>
>     Maybe for template changes we could have [TPL] too, but I would rather
>     not go too wild with introducing new commit "tags".
>
>     luci
>
>
>     On 22.1.2017 14:11, Gary Cunningham-Lee wrote:
>     > Hi,
>     >
>     > I need to follow CSS changes too, but I just check which
>     directories or
>     > files are involved in a commit; if it's in the themes directories, I
>     > know it's a CSS change (or Less + CSS change).
>     >
>     > Is the idea that the [CSS] tag would be used in combination with
>     one of
>     > the others, like [CSS][FIX], etc.? That seems ok to me. Using only
>     [CSS]
>     > wouldn't give enough information or the right information IMO. But
>     then
>     > if CSS file changes warrant a tag, is the same true for other file
>     > types? (Thinking about adding a [CSS] tag, I kind of see this
>     situation
>     > as a matrix with the nature-of-the-change tags on one axis and file
>     > types - or other category that [CSS] fits in - on another.)
>     >
>     > -- Gary
>     >
>     >
>     > On 1/22/2017 8:10 PM, Brendan Ferguson wrote:
>     >> Ya, im up for that.
>     >>
>     >> The CSS, THE, TEM, DES, .... or something that denotes that its a
>     change
>     >> made that could effect template design somewhere down the cascade
>     line.
>     >> That means ether a css change in tiki_base (that could effect our
>     >> themes, or custom themes) or a change in HTML structure (that could
>     >> mismatch css selectors) or a removal of a class or ID (that could
>     effect
>     >> css selectors). Might be a good way to track down regressions in css.
>     >>
>     >> I would like to see them on there own page. When I make commits I
>     very
>     >> often do a google search for "Tiki Commit Codes" and give them a once
>     >> over. I never want to spend a lot of time on it and scrolling to the
>     >> bottom of the page is a pain. A Short and long description would
>     also be
>     >> handy, so an overview is posable, with more detail if im not exactly
>     >> sure, or if Ive chosen the code I want to use, but just want to make
>     >> sure it fits properly.
>     >>
>     >> Brendan
>     >>
>     >> On Fri, Jan 20, 2017 at 9:43 PM, Jonny Bradley <[hidden email]
>     <mailto:[hidden email]>
>     >> <mailto:[hidden email] <mailto:[hidden email]>>> wrote:
>     >>
>     >>      Hi all
>     >>
>     >>      I think it is time that we overhauled the commit tags such
>     as [NEW],
>     >>      [ENH], [FIX] etc and make the documentation a bit clearer
>     not that
>     >>      we have several new developers committing code (which is
>     absolutely
>     >>      fantastic, by the way!).
>     >>
>     >>      This can be found here:
>     >>      https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>
>     >>
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes
>     <https://dev.tiki.org/Commit+Code#Step_6:_Commit_Your_Changes>> and
>     >>      in changelog.txt.
>     >>
>     >>      I should also say this really doesn't matter very much, so
>     i'm not
>     >>      saying anyone needs to re-commit anything, it's just some
>     ascii in
>     >>      the changelog file in the end so don't take this as major
>     criticism,
>     >>      just trying to straighten things out :)
>     >>
>     >>      I can see why Ricardo decided to tag this as a NEW thing, as
>     it's
>     >>      new to satis, but from my point of view it isn't a new
>     feature in
>     >>      any respect. We recently added [UPD] for composer and third
>     party
>     >>      library updates so i think this would suit that.
>     >>
>     >>      However, the difference between NEW and ENH and MOD is
>     always a bit
>     >>      blurry, i've generally taken NEW to be for things that would
>     need a
>     >>      new page on doc.tiki.org <http://doc.tiki.org>
>     <http://doc.tiki.org> (a new plugin, field
>     >>      type or feature) and ENH as a new section or paragraph on an
>     >>      existing DOC page. MOD is all together more mysterious... ;)
>     >>
>     >>      Do we need any new tags? Maybe CSS which was discussed
>     before once?
>     >>
>     >>      I think they should be easier to find on dev.t.o, maybe on
>     it's own
>     >>      page and then be included in others?
>     >>
>     >>      Anyway, i thought i'd start the discussion off, the main
>     thing is
>     >>      that things are being fixed and added, and that's great!
>     Something
>     >>      for the https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>
>     >>      <https://tiki.org/TikiFestFosdem2017
>     <https://tiki.org/TikiFestFosdem2017>> maybe?
>     >>
>     >>      jonny
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>
>     >>      > On 20 Jan 2017, at 00:48, [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>> wrote:
>     >>      >
>     >>      > Revision: 60944
>     >>      >          http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>
>     >>      <http://sourceforge.net/p/tikiwiki/code/60944
>     <http://sourceforge.net/p/tikiwiki/code/60944>>
>     >>      > Author:   rjsmelo
>     >>      > Date:     2017-01-20 00:48:30 +0000 (Fri, 20 Jan 2017)
>     >>      > Log Message:
>     >>      > -----------
>     >>      > [NEW] Upgrade adodb to 5.20.9, add package to satis
>     >>      >
>     >>      > Modified Paths:
>     >>      > --------------
>     >>      >    trunk/doc/devtools/satis.json
>     >>      >
>     >>      > Modified: trunk/doc/devtools/satis.json
>     >>      >
>     ===================================================================
>     >>      > --- trunk/doc/devtools/satis.json     2017-01-20 00:12:26
>     UTC (rev
>     >>      60943)
>     >>      > +++ trunk/doc/devtools/satis.json     2017-01-20 00:48:30
>     UTC (rev
>     >>      60944)
>     >>      > @@ -20,6 +20,17 @@
>     >>      >               {
>     >>      >                       "type": "package",
>     >>      >                       "package": {
>     >>      > +                             "name": "adodb/adodb-php",
>     >>      > +                             "version": "5.20.9",
>     >>      > +                             "dist": {
>     >>      > +                                     "url":
>     >>      "https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>
>     >>      <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip
>     <https://github.com/ADOdb/ADOdb/archive/v5.20.9.zip>>",
>     >>      > +                                     "type": "zip"
>     >>      > +                             }
>     >>      > +                     }
>     >>      > +             },
>     >>      > +             {
>     >>      > +                     "type": "package",
>     >>      > +                     "package": {
>     >>      >                               "name": "afarkas/html5shiv",
>     >>      >                               "version": "3.6.2",
>     >>      >                               "dist": {
>     >>      >
>     >>      > This was sent by the SourceForge.net collaborative development
>     >>      platform, the world's largest Open Source development site.
>     >>      >
>     >>      >
>     >>      >
>     >>
>     ------------------------------------------------------------------------------
>     >>      > Check out the vibrant tech community on one of the world's
>     most
>     >>      > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      > _______________________________________________
>     >>      > Tikiwiki-cvs mailing list
>     >>      > [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs>>
>     >>      >
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >>      Check out the vibrant tech community on one of the world's most
>     >>      engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>      _______________________________________________
>     >>      TikiWiki-devel mailing list
>     >>      [hidden email]
>     <mailto:[hidden email]>
>     >>      <mailto:[hidden email]
>     <mailto:[hidden email]>>
>     >>      https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>      <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>>
>     >>
>     >>
>     >>
>     >>
>     >>
>     ------------------------------------------------------------------------------
>     >> Check out the vibrant tech community on one of the world's most
>     >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     >>
>     >>
>     >>
>     >> _______________________________________________
>     >> TikiWiki-devel mailing list
>     >> [hidden email]
>     <mailto:[hidden email]>
>     >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>     >>
>     >
>     >
>     ------------------------------------------------------------------------------
>     > Check out the vibrant tech community on one of the world's most
>     > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     > _______________________________________________
>     > TikiWiki-devel mailing list
>     > [hidden email]
>     <mailto:[hidden email]>
>     > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>     _______________________________________________
>     TikiWiki-devel mailing list
>     [hidden email]
>     <mailto:[hidden email]>
>     https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>     <https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel>
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
12
Loading...