[Tiki-devel] Commit tags, another round :)

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Tiki-devel] Commit tags, another round :)

Bernard Sfez-3
Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Tiki-devel] Commit tags, another round :)

luciash d' being

I think if you just fix a typo only or do a code reformatting it does not necessarily need to be in the changelog.txt so you just commit with message "just a typo" or "code reformatting only" without any tagging...

luci


On 30.1.2017 7:46, Bernard Sfez wrote:
Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

[Tiki-devel] RE : Commit tags, another round :)

Cloutier, Philippe (RESSOURCE EXTERNE)
In reply to this post by Bernard Sfez-3
We have been struggling for years to get the meaning of a limited set of defined commit tags respected. I do not see the point of introducing undefined tags anyway.

A [UPD] tag is already defined.
I believe we already have a convention for reversions (maybe not quite a tag, but [rv/12345] to revert r12345). I think it should be documented.


De : Bernard Sfez [[hidden email]]
Envoyé : 30 janvier 2017 01:46
À : Tiki developers
Objet : [Tiki-devel] Commit tags, another round :)

Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Tiki-devel] RE : Commit tags, another round :)

luciash d' being

Hmm, I thought it is actually rb for rollback: [rb/r12345] (similarly we have [bp/r12345] for backports)


luci



On 30.1.2017 21:27, Cloutier, Philippe (RESSOURCE EXTERNE) wrote:
We have been struggling for years to get the meaning of a limited set of defined commit tags respected. I do not see the point of introducing undefined tags anyway.

A [UPD] tag is already defined.
I believe we already have a convention for reversions (maybe not quite a tag, but [rv/12345] to revert r12345). I think it should be documented.


De : Bernard Sfez [[hidden email]]
Envoyé : 30 janvier 2017 01:46
À : Tiki developers
Objet : [Tiki-devel] Commit tags, another round :)

Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

[Tiki-devel] RE : RE : Commit tags, another round :)

Cloutier, Philippe (RESSOURCE EXTERNE)
I was not sure. After a few greps, it seems none of them is used significantly.

De : luciash [[hidden email]]
Envoyé : 30 janvier 2017 15:44
À : Tiki developers
Objet : Re: [Tiki-devel] RE : Commit tags, another round :)

Hmm, I thought it is actually rb for rollback: [rb/r12345] (similarly we have [bp/r12345] for backports)


luci



On 30.1.2017 21:27, Cloutier, Philippe (RESSOURCE EXTERNE) wrote:
We have been struggling for years to get the meaning of a limited set of defined commit tags respected. I do not see the point of introducing undefined tags anyway.

A [UPD] tag is already defined.
I believe we already have a convention for reversions (maybe not quite a tag, but [rv/12345] to revert r12345). I think it should be documented.


De : Bernard Sfez [[hidden email]]
Envoyé : 30 janvier 2017 01:46
À : Tiki developers
Objet : [Tiki-devel] Commit tags, another round :)

Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Tiki-devel] RE : RE : Commit tags, another round :)

Bernard Sfez-3
Hi,


(feel free to edit text).

Bernard



On 30 Jan 2017, at 23:03 , Cloutier, Philippe (RESSOURCE EXTERNE) <[hidden email]> wrote:

I was not sure. After a few greps, it seems none of them is used significantly.

De : luciash [[hidden email]]
Envoyé : 30 janvier 2017 15:44
À : Tiki developers
Objet : Re: [Tiki-devel] RE : Commit tags, another round :)

Hmm, I thought it is actually rb for rollback: [rb/r12345] (similarly we have [bp/r12345] for backports)

luci


On 30.1.2017 21:27, Cloutier, Philippe (RESSOURCE EXTERNE) wrote:
We have been struggling for years to get the meaning of a limited set of defined commit tags respected. I do not see the point of introducing undefined tags anyway.

A [UPD] tag is already defined.
I believe we already have a convention for reversions (maybe not quite a tag, but [rv/12345] to revert r12345). I think it should be documented.


De : Bernard Sfez [[hidden email]]
Envoyé : 30 janvier 2017 01:46
À : Tiki developers
Objet : [Tiki-devel] Commit tags, another round :)

Hi,

I had some discussions outside the list about tags and came to me a simple question after getting several advises.

When committing one MUST use only the tag from this list : https://dev.tiki.org/tiki-index.php?page=Commit%20Code&pagenum=2#Step_5:_Commit_Your_Changes ?
Or he can set any tag relevant if missing ?

IE:
* When updating code from Google for Google analytic = [UPD]
* Adding removing space or tab = [TYPO]
* Reverting [REV]
etc…



Bernard Sfez | bsfez.com



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel