Quantcast

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61827] trunk/templates/admin/include_features.tpl

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61827] trunk/templates/admin/include_features.tpl

Cloutier, Philippe (RESSOURCE EXTERNE)
Hi Bernard,
This commit message is fairly vague. It would help to specify the affected tab and to link to the related tikiwiki-devel discussion of background. Note that there is no [UI] tag.

As for substance, I find the result pretty confusing. What do "Secondary features" and "Additional features" mean, and how do they differ?

> -----Message d'origine-----
> De : [hidden email] [mailto:[hidden email]]
> Envoyé : 23 mars 2017 03:50
> À : [hidden email]
> Objet : [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61827] trunk/templates/admin/include_features.tpl
>
> Revision: 61827
>           http://sourceforge.net/p/tikiwiki/code/61827
> Author:   yonixxx
> Date:     2017-03-23 07:49:31 +0000 (Thu, 23 Mar 2017)
> Log Message:
> -----------
> [UI] Better formatting and section'ing
>
> Modified Paths:
> --------------
>     trunk/templates/admin/include_features.tpl
>
> Modified: trunk/templates/admin/include_features.tpl
> ===================================================================
> --- trunk/templates/admin/include_features.tpl 2017-03-22 23:53:26 UTC (rev 61826)
> +++ trunk/templates/admin/include_features.tpl 2017-03-23 07:49:31 UTC (rev 61827)
> @@ -26,7 +26,6 @@
>
>   <fieldset>
>   <legend>{tr}Main features{/tr}</legend>
> -
>   <div class="admin clearfix form-group featurelist">
>   {preference name=feature_wiki}
>   {preference name=feature_file_galleries} @@ -34,35 +33,63
> @@
>   {preference name=feature_articles}
>   {preference name=feature_forums}
>   {preference name=feature_trackers}
> - {preference name=feature_polls}
> - {preference name=feature_sheet}
>   {preference name=feature_calendar}
> - {preference name=feature_newsletters}
> - {preference name=feature_banners}
> - {preference name=feature_categories}
> - {preference name=feature_freetags}
>   {preference name=feature_search}
>   </div>
> -
>   </fieldset>
>
>   <fieldset>
> - <legend>{tr}Additional features{/tr}</legend>
> + <legend>{tr}Secondary features{/tr}</legend>
>
>   <div class="admin clearfix form-group featurelist">
> + {preference name=feature_categories}
> + {preference name=feature_freetags}
> + {preference name=feature_polls}
> + {preference name=feature_quizzes}
>   {preference name=feature_surveys}
> - {preference name=feature_directory}
> - {preference name=feature_quizzes}
> + {preference name=feature_newsletters}
>   {preference name=feature_shoutbox}
>   {preference name=feature_minichat}
>   {preference name=feature_live_support}
> - {preference name=feature_tell_a_friend}
> - {preference name=feature_share}
> - {preference name=feature_credits}
> - {preference name=feature_time_sheet}
> - {preference name=feature_invoice}
> - {preference name=feature_accounting}
> - {preference name=payment_feature}
> + </div>
> + </fieldset>
> +
> + <fieldset>
> + <legend>{tr}Administrative features{/tr}</legend>
> + <div class="admin clearfix form-group featurelist">
> + <div class="adminoptionboxchild">
> + <fieldset>
> + <legend>{tr}Watches{/tr}</legend>
> + {preference name=feature_user_watches}
> + {preference name=feature_group_watches}
> + {preference
> name=feature_daily_report_watches}
> + <div class="adminoptionboxchild"
> id="feature_daily_report_watches_childcontainer">
> + {preference
> name=dailyreports_enabled_for_new_users}
> + </div>
> + {preference
> name=feature_user_watches_translations}
> + {preference
> name=feature_user_watches_languages}
> + {preference name=feature_groupalert}
> + </fieldset>
> + </div>
> + {preference name=feature_actionlog}
> + {preference name=feature_banners}
> + {preference name=feature_contribution}
> + {preference name=feature_copyright}
> + {preference name=feature_comm}
> + {preference name=feature_dynamic_content}
> + {preference name=feature_perspective}
> + {preference name=feature_sefurl}
> + {preference name=feature_html_pages}
> + {preference name=feature_htmlfeed}
> + {preference name=feature_areas}
> + </div>
> + </fieldset>
> +
> + <fieldset>
> + <legend>{tr}Additional features{/tr}</legend>
> + <div class="admin clearfix form-group featurelist">
> + {preference name=feature_sheet}
> + {preference name=feature_directory}
>   {preference name=feature_draw}
>   <div class="adminoptionboxchild"
> id="feature_draw_childcontainer">
>   {preference name=feature_draw_hide_buttons} @@ -
> 71,28 +98,32 @@
>   {preference name=feature_draw_in_userfiles}
>   </div>
>   </div>
> -
> + <div class="adminoptionboxchild">
> + <fieldset>
> + <legend>{tr}Payment and
> Accounting{/tr}</legend>
> + {preference name=feature_credits}
> + {preference name=feature_accounting}
> + {preference name=payment_feature}
> + {preference name=feature_invoice}
> + </fieldset>
> + </div>
> + <div class="adminoptionboxchild">
> + <fieldset>
> + <legend>{tr}Mail and Sharing{/tr}</legend>
> + {preference name=feature_socialnetworks}
> + {preference name=feature_tell_a_friend}
> + {preference name=feature_share}
> + {preference name=feature_webmail}
> + {preference name=feature_mailin}
> + </fieldset>
> + </div>
>   {preference name=feature_docs}
>   {preference name=feature_slideshow}
>   {preference name=feature_slideshow_pdfexport}
> - {preference name=feature_dynamic_content}
> - {preference name=feature_perspective}
> - {preference name=feature_areas}
> - {preference name=feature_sefurl}
> - {preference name=feature_webmail}
> - {preference name=feature_actionlog}
> - {preference name=feature_comm}
> - {preference name=feature_contribution}
> - {preference name=feature_copyright}
> - {preference name=feature_mailin}
> -
> + {preference name=feature_time_sheet}
>   {preference name=feature_faqs}
>   {preference name=feature_galleries}
> - {preference name=feature_html_pages}
> -
> - {preference name=feature_htmlfeed}
>   {preference name=feature_futurelinkprotocol}
> -
>   {preference name=feature_reports}
>   </div>
>   </fieldset>
> @@ -101,10 +132,7 @@
>   <legend>{tr}Interaction with online services or other
> software{/tr}</legend>
>   <div class="admin clearfix featurelist">
>   {preference name=connect_feature}
> - {preference name=feature_socialnetworks}
> -
>   {preference name=feature_kaltura}
> -
>   {preference name=zotero_enabled}
>   <div class="adminoptionboxchild"
> id="zotero_enabled_childcontainer">
>   {if $prefs.zotero_client_key and
> $prefs.zotero_client_secret and $prefs.zotero_group_id} @@ -115,28 +143,9 @@
>   {preference name=zotero_group_id}
>   {preference name=zotero_style}
>   </div>
> -
>   </div>
>   {preference name=feature_htmlfeed}
>   </fieldset>
> -
> -
> - <fieldset>
> - <legend>{tr}Watches{/tr}</legend>
> -
> - <div class="admin clearfix featurelist">
> - {preference name=feature_user_watches}
> - {preference name=feature_group_watches}
> - {preference name=feature_daily_report_watches}
> - <div class="adminoptionboxchild"
> id="feature_daily_report_watches_childcontainer">
> - {preference
> name=dailyreports_enabled_for_new_users}
> - </div>
> - {preference name=feature_user_watches_translations}
> - {preference name=feature_user_watches_languages}
> - {preference name=feature_groupalert}
> - </div>
> - </fieldset>
> -
>   {/tab}
>
>   {tab name="{tr}Interface{/tr}" key=interface}
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open
> Source development site.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot _______________________________________________
> Tikiwiki-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61827] trunk/templates/admin/include_features.tpl

Bernard Sfez-3
Hello Philippe,

I agree it is very vague. Couldn’t find a lot more to say without giving too much details.

About the tag I know but I’ve seen from several other commits that it is ok to use such tag.
It won’t be added in the changelog but still give a good hint about the commit.

Is it possible to add an url in the commit text ?

Bernard


On 23 Mar 2017, at 19:36 , Cloutier, Philippe (RESSOURCE EXTERNE) <[hidden email]> wrote:

Hi Bernard,
This commit message is fairly vague. It would help to specify the affected tab and to link to the related tikiwiki-devel discussion of background. Note that there is no [UI] tag.

As for substance, I find the result pretty confusing. What do "Secondary features" and "Additional features" mean, and how do they differ?

-----Message d'origine-----
De : [hidden email] [[hidden email]]
Envoyé : 23 mars 2017 03:50
À : [hidden email]
Objet : [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61827] trunk/templates/admin/include_features.tpl

Revision: 61827
         http://sourceforge.net/p/tikiwiki/code/61827
Author:   yonixxx
Date:     2017-03-23 07:49:31 +0000 (Thu, 23 Mar 2017)
Log Message:
-----------
[UI] Better formatting and section'ing

Modified Paths:
--------------
   trunk/templates/admin/include_features.tpl

Modified: trunk/templates/admin/include_features.tpl
===================================================================
--- trunk/templates/admin/include_features.tpl 2017-03-22 23:53:26 UTC (rev 61826)
+++ trunk/templates/admin/include_features.tpl 2017-03-23 07:49:31 UTC (rev 61827)
@@ -26,7 +26,6 @@

<fieldset>
<legend>{tr}Main features{/tr}</legend>
-
<div class="admin clearfix form-group featurelist">
{preference name=feature_wiki}
{preference name=feature_file_galleries} @@ -34,35 +33,63
@@
{preference name=feature_articles}
{preference name=feature_forums}
{preference name=feature_trackers}
- {preference name=feature_polls}
- {preference name=feature_sheet}
{preference name=feature_calendar}
- {preference name=feature_newsletters}
- {preference name=feature_banners}
- {preference name=feature_categories}
- {preference name=feature_freetags}
{preference name=feature_search}
</div>
-
</fieldset>

<fieldset>
- <legend>{tr}Additional features{/tr}</legend>
+ <legend>{tr}Secondary features{/tr}</legend>

<div class="admin clearfix form-group featurelist">
+ {preference name=feature_categories}
+ {preference name=feature_freetags}
+ {preference name=feature_polls}
+ {preference name=feature_quizzes}
{preference name=feature_surveys}
- {preference name=feature_directory}
- {preference name=feature_quizzes}
+ {preference name=feature_newsletters}
{preference name=feature_shoutbox}
{preference name=feature_minichat}
{preference name=feature_live_support}
- {preference name=feature_tell_a_friend}
- {preference name=feature_share}
- {preference name=feature_credits}
- {preference name=feature_time_sheet}
- {preference name=feature_invoice}
- {preference name=feature_accounting}
- {preference name=payment_feature}
+ </div>
+ </fieldset>
+
+ <fieldset>
+ <legend>{tr}Administrative features{/tr}</legend>
+ <div class="admin clearfix form-group featurelist">
+ <div class="adminoptionboxchild">
+ <fieldset>
+ <legend>{tr}Watches{/tr}</legend>
+ {preference name=feature_user_watches}
+ {preference name=feature_group_watches}
+ {preference
name=feature_daily_report_watches}
+ <div class="adminoptionboxchild"
id="feature_daily_report_watches_childcontainer">
+ {preference
name=dailyreports_enabled_for_new_users}
+ </div>
+ {preference
name=feature_user_watches_translations}
+ {preference
name=feature_user_watches_languages}
+ {preference name=feature_groupalert}
+ </fieldset>
+ </div>
+ {preference name=feature_actionlog}
+ {preference name=feature_banners}
+ {preference name=feature_contribution}
+ {preference name=feature_copyright}
+ {preference name=feature_comm}
+ {preference name=feature_dynamic_content}
+ {preference name=feature_perspective}
+ {preference name=feature_sefurl}
+ {preference name=feature_html_pages}
+ {preference name=feature_htmlfeed}
+ {preference name=feature_areas}
+ </div>
+ </fieldset>
+
+ <fieldset>
+ <legend>{tr}Additional features{/tr}</legend>
+ <div class="admin clearfix form-group featurelist">
+ {preference name=feature_sheet}
+ {preference name=feature_directory}
{preference name=feature_draw}
<div class="adminoptionboxchild"
id="feature_draw_childcontainer">
{preference name=feature_draw_hide_buttons} @@ -
71,28 +98,32 @@
{preference name=feature_draw_in_userfiles}
</div>
</div>
-
+ <div class="adminoptionboxchild">
+ <fieldset>
+ <legend>{tr}Payment and
Accounting{/tr}</legend>
+ {preference name=feature_credits}
+ {preference name=feature_accounting}
+ {preference name=payment_feature}
+ {preference name=feature_invoice}
+ </fieldset>
+ </div>
+ <div class="adminoptionboxchild">
+ <fieldset>
+ <legend>{tr}Mail and Sharing{/tr}</legend>
+ {preference name=feature_socialnetworks}
+ {preference name=feature_tell_a_friend}
+ {preference name=feature_share}
+ {preference name=feature_webmail}
+ {preference name=feature_mailin}
+ </fieldset>
+ </div>
{preference name=feature_docs}
{preference name=feature_slideshow}
{preference name=feature_slideshow_pdfexport}
- {preference name=feature_dynamic_content}
- {preference name=feature_perspective}
- {preference name=feature_areas}
- {preference name=feature_sefurl}
- {preference name=feature_webmail}
- {preference name=feature_actionlog}
- {preference name=feature_comm}
- {preference name=feature_contribution}
- {preference name=feature_copyright}
- {preference name=feature_mailin}
-
+ {preference name=feature_time_sheet}
{preference name=feature_faqs}
{preference name=feature_galleries}
- {preference name=feature_html_pages}
-
- {preference name=feature_htmlfeed}
{preference name=feature_futurelinkprotocol}
-
{preference name=feature_reports}
</div>
</fieldset>
@@ -101,10 +132,7 @@
<legend>{tr}Interaction with online services or other
software{/tr}</legend>
<div class="admin clearfix featurelist">
{preference name=connect_feature}
- {preference name=feature_socialnetworks}
-
{preference name=feature_kaltura}
-
{preference name=zotero_enabled}
<div class="adminoptionboxchild"
id="zotero_enabled_childcontainer">
{if $prefs.zotero_client_key and
$prefs.zotero_client_secret and $prefs.zotero_group_id} @@ -115,28 +143,9 @@
{preference name=zotero_group_id}
{preference name=zotero_style}
</div>
-
</div>
{preference name=feature_htmlfeed}
</fieldset>
-
-
- <fieldset>
- <legend>{tr}Watches{/tr}</legend>
-
- <div class="admin clearfix featurelist">
- {preference name=feature_user_watches}
- {preference name=feature_group_watches}
- {preference name=feature_daily_report_watches}
- <div class="adminoptionboxchild"
id="feature_daily_report_watches_childcontainer">
- {preference
name=dailyreports_enabled_for_new_users}
- </div>
- {preference name=feature_user_watches_translations}
- {preference name=feature_user_watches_languages}
- {preference name=feature_groupalert}
- </div>
- </fieldset>
-
{/tab}

{tab name="{tr}Interface{/tr}" key=interface}

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!
http://sdm.link/slashdot _______________________________________________
Tikiwiki-cvs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Tikiwiki-cvs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs

Bernard Sfez | bsfez.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Loading...