Quantcast

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513] branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513] branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

Geoff - Enmore Services
Luci (and copied to dev list so that others can check as well)

I'm not sure that the problem is to do with my commit - but I could of
course be wrong! And if it is I will of course do anything I can to sort it.

But my commit simply added additional selectors to the form's label fields
which should be completely benign.

Looking at the wish page with Firebug however I see the following:

<div class="wikiplugin_tracker" style="display: none;">

Ie a style parameter is on the outer most div  of the tracker with display
as 'none' which I don't see how my commit could have had that effect.

In addition, I made this commit for a site of my own and carefully checked
it before hand and it all works OK

Can anyone else understand what may have happened here?

geoff




-----Original Message-----
From: luciash [mailto:[hidden email]]
Sent: 09 March 2017 10:37
To: CVS/SVN commits information <[hidden email]>
Subject: Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513]
branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

Hi Geoff,

for some reason this is now hiding the whole form to submit new bugs on
https://dev.tiki.org/Make+a+wish and only the Submit button appears.

Can you please fix that ASAP or rollback?

Thanks,

luci


On 03/06/2017 12:02 AM, [hidden email] wrote:

> Revision: 61513
>            http://sourceforge.net/p/tikiwiki/code/61513
> Author:   eromneg
> Date:     2017-03-05 23:02:06 +0000 (Sun, 05 Mar 2017)
> Log Message:
> -----------
> [ENH] [bp61512] additional tracker fieldId selector to allow more css
> customisation
>
> Modified Paths:
> --------------
>      branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>
> Modified: branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
> ===================================================================
> --- branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
22:51:43 UTC (rev 61512)
> +++ branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
23:02:06 UTC (rev 61513)
> @@ -1771,7 +1771,7 @@
>
$smarty->assign('f_'.$f['permName'], $prettyout);
>   }
>   } else {
> - $back.= '<div class="form-group
tracker_input_label"'; // <tr><td class="tracker_input_label"
> + $back.= '<div class="form-group
tracker_input_label tracker_field' . $f['fieldId'] . '"'; // <tr><td
class="tracker_input_label"
>  
>   // If type is has a samerow param
and samerow is "No", show text on one line and the input field on the next
>   $isTextOnSameRow = true;
> @@ -1840,7 +1840,7 @@
>  
>   if ($f['type'] != 'S' && empty($tpl) &&
empty($wiki)) {
>   if ($showfieldsdesc == 'y') {
> - $back .= '<div
class="form-group tracker-help-block"><div class="' . $labelclass
> + $back .= '<div
class="form-group tracker-help-block
> +tracker_field' . $f['fieldId'] . ' "><div class="' . $labelclass
>   . ' control-label
sr-only">Label</div><div class="' . $inputclass
>   . '
trackerplugindesc help-block">';
>  
>
> This was sent by the SourceForge.net collaborative development platform,
the world's largest Open Source development site.
>
>
> ----------------------------------------------------------------------
> -------- Check out the vibrant tech community on one of the world's
> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot 
> _______________________________________________
> Tikiwiki-cvs mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs


----------------------------------------------------------------------------
--
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Tikiwiki-cvs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs


-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7998 / Virus Database: 4756/14079 - Release Date: 03/09/17



-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7998 / Virus Database: 4756/14079 - Release Date: 03/09/17


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513] branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

Jonny Bradley-4
It was just some custom js on the page that was doing

   $(".tracker_field56").parent().hide();

to hide the resolution status field so i just changed it to

    $(".tracker_field56").hide();

and all is well.

Not really a regression, just some "loose" jQuery selecting really ;)

jb




> On 9 Mar 2017, at 11:32, Geoff - Enmore Services <[hidden email]> wrote:
>
> Luci (and copied to dev list so that others can check as well)
>
> I'm not sure that the problem is to do with my commit - but I could of
> course be wrong! And if it is I will of course do anything I can to sort it.
>
> But my commit simply added additional selectors to the form's label fields
> which should be completely benign.
>
> Looking at the wish page with Firebug however I see the following:
>
> <div class="wikiplugin_tracker" style="display: none;">
>
> Ie a style parameter is on the outer most div  of the tracker with display
> as 'none' which I don't see how my commit could have had that effect.
>
> In addition, I made this commit for a site of my own and carefully checked
> it before hand and it all works OK
>
> Can anyone else understand what may have happened here?
>
> geoff
>
>
>
>
>> -----Original Message-----
>> From: luciash [mailto:[hidden email]]
>> Sent: 09 March 2017 10:37
>> To: CVS/SVN commits information <[hidden email]>
>> Subject: Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513]
>> branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php
>>
>> Hi Geoff,
>>
>> for some reason this is now hiding the whole form to submit new bugs on
>> https://dev.tiki.org/Make+a+wish and only the Submit button appears.
>>
>> Can you please fix that ASAP or rollback?
>>
>> Thanks,
>>
>> luci
>>
>>
>> On 03/06/2017 12:02 AM, [hidden email] wrote:
>>> Revision: 61513
>>>           http://sourceforge.net/p/tikiwiki/code/61513
>>> Author:   eromneg
>>> Date:     2017-03-05 23:02:06 +0000 (Sun, 05 Mar 2017)
>>> Log Message:
>>> -----------
>>> [ENH] [bp61512] additional tracker fieldId selector to allow more css
>>> customisation
>>>
>>> Modified Paths:
>>> --------------
>>>     branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>>
>>> Modified: branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>> ===================================================================
>>> --- branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>> 22:51:43 UTC (rev 61512)
>>> +++ branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>> 23:02:06 UTC (rev 61513)
>>> @@ -1771,7 +1771,7 @@
>>>
>> $smarty->assign('f_'.$f['permName'], $prettyout);
>>>   }
>>>   } else {
>>> - $back.= '<div class="form-group
>> tracker_input_label"'; // <tr><td class="tracker_input_label"
>>> + $back.= '<div class="form-group
>> tracker_input_label tracker_field' . $f['fieldId'] . '"'; // <tr><td
>> class="tracker_input_label"
>>>
>>>   // If type is has a samerow param
>> and samerow is "No", show text on one line and the input field on the next
>>>   $isTextOnSameRow = true;
>>> @@ -1840,7 +1840,7 @@
>>>
>>>   if ($f['type'] != 'S' && empty($tpl) &&
>> empty($wiki)) {
>>>   if ($showfieldsdesc == 'y') {
>>> - $back .= '<div
>> class="form-group tracker-help-block"><div class="' . $labelclass
>>> + $back .= '<div
>> class="form-group tracker-help-block
>>> +tracker_field' . $f['fieldId'] . ' "><div class="' . $labelclass
>>>   . ' control-label
>> sr-only">Label</div><div class="' . $inputclass
>>>   . '
>> trackerplugindesc help-block">';
>>>
>>>
>>> This was sent by the SourceForge.net collaborative development platform,
>> the world's largest Open Source development site.
>>>
>>>
>>> ----------------------------------------------------------------------
>>> -------- Check out the vibrant tech community on one of the world's
>>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot 
>>> _______________________________________________
>>> Tikiwiki-cvs mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>
[snip]
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513] branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

luciash d' being
Ah, yup, thanks Jonny!

luci


On 03/09/2017 12:41 PM, Jonny Bradley wrote:

> It was just some custom js on the page that was doing
>
>     $(".tracker_field56").parent().hide();
>
> to hide the resolution status field so i just changed it to
>
>      $(".tracker_field56").hide();
>
> and all is well.
>
> Not really a regression, just some "loose" jQuery selecting really ;)
>
> jb
>
>
>
>
>> On 9 Mar 2017, at 11:32, Geoff - Enmore Services <[hidden email]> wrote:
>>
>> Luci (and copied to dev list so that others can check as well)
>>
>> I'm not sure that the problem is to do with my commit - but I could of
>> course be wrong! And if it is I will of course do anything I can to sort it.
>>
>> But my commit simply added additional selectors to the form's label fields
>> which should be completely benign.
>>
>> Looking at the wish page with Firebug however I see the following:
>>
>> <div class="wikiplugin_tracker" style="display: none;">
>>
>> Ie a style parameter is on the outer most div  of the tracker with display
>> as 'none' which I don't see how my commit could have had that effect.
>>
>> In addition, I made this commit for a site of my own and carefully checked
>> it before hand and it all works OK
>>
>> Can anyone else understand what may have happened here?
>>
>> geoff
>>
>>
>>
>>
>>> -----Original Message-----
>>> From: luciash [mailto:[hidden email]]
>>> Sent: 09 March 2017 10:37
>>> To: CVS/SVN commits information <[hidden email]>
>>> Subject: Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513]
>>> branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php
>>>
>>> Hi Geoff,
>>>
>>> for some reason this is now hiding the whole form to submit new bugs on
>>> https://dev.tiki.org/Make+a+wish and only the Submit button appears.
>>>
>>> Can you please fix that ASAP or rollback?
>>>
>>> Thanks,
>>>
>>> luci
>>>
>>>
>>> On 03/06/2017 12:02 AM, [hidden email] wrote:
>>>> Revision: 61513
>>>>            http://sourceforge.net/p/tikiwiki/code/61513
>>>> Author:   eromneg
>>>> Date:     2017-03-05 23:02:06 +0000 (Sun, 05 Mar 2017)
>>>> Log Message:
>>>> -----------
>>>> [ENH] [bp61512] additional tracker fieldId selector to allow more css
>>>> customisation
>>>>
>>>> Modified Paths:
>>>> --------------
>>>>      branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>>>
>>>> Modified: branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>>> ===================================================================
>>>> --- branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>>> 22:51:43 UTC (rev 61512)
>>>> +++ branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>>> 23:02:06 UTC (rev 61513)
>>>> @@ -1771,7 +1771,7 @@
>>>>
>>> $smarty->assign('f_'.$f['permName'], $prettyout);
>>>>   }
>>>>   } else {
>>>> - $back.= '<div class="form-group
>>> tracker_input_label"'; // <tr><td class="tracker_input_label"
>>>> + $back.= '<div class="form-group
>>> tracker_input_label tracker_field' . $f['fieldId'] . '"'; // <tr><td
>>> class="tracker_input_label"
>>>>   // If type is has a samerow param
>>> and samerow is "No", show text on one line and the input field on the next
>>>>   $isTextOnSameRow = true;
>>>> @@ -1840,7 +1840,7 @@
>>>>
>>>>   if ($f['type'] != 'S' && empty($tpl) &&
>>> empty($wiki)) {
>>>>   if ($showfieldsdesc == 'y') {
>>>> - $back .= '<div
>>> class="form-group tracker-help-block"><div class="' . $labelclass
>>>> + $back .= '<div
>>> class="form-group tracker-help-block
>>>> +tracker_field' . $f['fieldId'] . ' "><div class="' . $labelclass
>>>>   . ' control-label
>>> sr-only">Label</div><div class="' . $inputclass
>>>>   . '
>>> trackerplugindesc help-block">';
>>>>
>>>> This was sent by the SourceForge.net collaborative development platform,
>>> the world's largest Open Source development site.
>>>>
>>>> ----------------------------------------------------------------------
>>>> -------- Check out the vibrant tech community on one of the world's
>>>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>>> _______________________________________________
>>>> Tikiwiki-cvs mailing list
>>>> [hidden email]
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
> [snip]
> ------------------------------------------------------------------------------
> Announcing the Oxford Dictionaries API! The API offers world-renowned
> dictionary content that is easy and intuitive to access. Sign up for an
> account today to start using our lexical data to power your apps and
> projects. Get started today and enter our developer competition.
> http://sdm.link/oxford
> _______________________________________________
> TikiWiki-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513] branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

Geoff - Enmore Services
In reply to this post by Jonny Bradley-4
Ahhh, the law of 'unintended consequences"

:-)

Thanks Jonny

-----Original Message-----
From: Jonny Bradley [mailto:[hidden email]]
Sent: 09 March 2017 11:42
To: Tiki developers <[hidden email]>
Subject: Re: [Tiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513]
branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php

It was just some custom js on the page that was doing

   $(".tracker_field56").parent().hide();

to hide the resolution status field so i just changed it to

    $(".tracker_field56").hide();

and all is well.

Not really a regression, just some "loose" jQuery selecting really ;)

jb




> On 9 Mar 2017, at 11:32, Geoff - Enmore Services
<[hidden email]> wrote:
>
> Luci (and copied to dev list so that others can check as well)
>
> I'm not sure that the problem is to do with my commit - but I could of
> course be wrong! And if it is I will of course do anything I can to sort
it.

>
> But my commit simply added additional selectors to the form's label
> fields which should be completely benign.
>
> Looking at the wish page with Firebug however I see the following:
>
> <div class="wikiplugin_tracker" style="display: none;">
>
> Ie a style parameter is on the outer most div  of the tracker with
> display as 'none' which I don't see how my commit could have had that
effect.

>
> In addition, I made this commit for a site of my own and carefully
> checked it before hand and it all works OK
>
> Can anyone else understand what may have happened here?
>
> geoff
>
>
>
>
>> -----Original Message-----
>> From: luciash [mailto:[hidden email]]
>> Sent: 09 March 2017 10:37
>> To: CVS/SVN commits information <[hidden email]>
>> Subject: Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[61513]
>> branches/16.x/lib/wiki-plugins/ wikiplugin_tracker.php
>>
>> Hi Geoff,
>>
>> for some reason this is now hiding the whole form to submit new bugs
>> on https://dev.tiki.org/Make+a+wish and only the Submit button appears.
>>
>> Can you please fix that ASAP or rollback?
>>
>> Thanks,
>>
>> luci
>>
>>
>> On 03/06/2017 12:02 AM, [hidden email] wrote:
>>> Revision: 61513
>>>           http://sourceforge.net/p/tikiwiki/code/61513
>>> Author:   eromneg
>>> Date:     2017-03-05 23:02:06 +0000 (Sun, 05 Mar 2017)
>>> Log Message:
>>> -----------
>>> [ENH] [bp61512] additional tracker fieldId selector to allow more
>>> css customisation
>>>
>>> Modified Paths:
>>> --------------
>>>     branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>>
>>> Modified: branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php
>>> ===================================================================
>>> --- branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>> 22:51:43 UTC (rev 61512)
>>> +++ branches/16.x/lib/wiki-plugins/wikiplugin_tracker.php 2017-03-05
>> 23:02:06 UTC (rev 61513)
>>> @@ -1771,7 +1771,7 @@
>>>
>> $smarty->assign('f_'.$f['permName'], $prettyout);
>>>   }
>>>   } else {
>>> - $back.= '<div class="form-group
>> tracker_input_label"'; // <tr><td class="tracker_input_label"
>>> + $back.= '<div class="form-group
>> tracker_input_label tracker_field' . $f['fieldId'] . '"'; // <tr><td
>> class="tracker_input_label"
>>>
>>>   // If type is has a samerow param
>> and samerow is "No", show text on one line and the input field on the
>> next
>>>   $isTextOnSameRow = true;
>>> @@ -1840,7 +1840,7 @@
>>>
>>>   if ($f['type'] != 'S' && empty($tpl) &&
>> empty($wiki)) {
>>>   if ($showfieldsdesc == 'y') {
>>> - $back .= '<div
>> class="form-group tracker-help-block"><div class="' . $labelclass
>>> + $back .= '<div
>> class="form-group tracker-help-block
>>> +tracker_field' . $f['fieldId'] . ' "><div class="' . $labelclass
>>>   . ' control-label
>> sr-only">Label</div><div class="' . $inputclass
>>>   . '
>> trackerplugindesc help-block">';
>>>
>>>
>>> This was sent by the SourceForge.net collaborative development
>>> platform,
>> the world's largest Open Source development site.
>>>
>>>
>>> --------------------------------------------------------------------
>>> --
>>> -------- Check out the vibrant tech community on one of the world's
>>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot 
>>> _______________________________________________
>>> Tikiwiki-cvs mailing list
>>> [hidden email]
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>
[snip]
----------------------------------------------------------------------------
--
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7998 / Virus Database: 4756/14079 - Release Date: 03/09/17



-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7998 / Virus Database: 4756/14079 - Release Date: 03/09/17


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
TikiWiki-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
Loading...